Use containment together with RequiresExplicitBinding annotation to check whether to append bound operations to navigation properties
#430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irvinesunday
requested review from
andrueastman,
baywet,
darrelmiller,
millicentachieng,
peombwa,
xuzhg and
zengin
as code owners
baywet
previously requested changes
Oct 3, 2023
|
|
||
| // So far, we only consider the non-containment | ||
| Debug.Assert(!NavigationProperty.ContainsTarget); | ||
| //Debug.Assert(!NavigationProperty.ContainsTarget); |
src/OoasGui/OoasGui.csproj
Outdated
| <PackageReference Include="Microsoft.CSharp" Version="4.7.0" /> | ||
| <PackageReference Include="Microsoft.OData.Edm" Version="7.18.0" /> | ||
| <PackageReference Include="Microsoft.OpenApi" Version="1.6.9" /> | ||
| <PackageReference Include="Microsoft.OpenApi" Version="1.6.4" /> |
There was a problem hiding this comment.
rebase, I'm not sure why we're downgrading dependencies here.
andrueastman
reviewed
Oct 4, 2023
src/OoasGui/MainForm.cs
Outdated
| oasRichTextBox.WordWrap = false; | ||
|
|
||
|
|
||
| verifyEdmModelcheckBox.Checked = false; |
There was a problem hiding this comment.
Probably need to double check if this change is intended as well.
irvinesunday
force-pushed
the
is/explicit-operations-binding
branch
from
39a325d to
5c97ab1
Compare
|
SonarCloud Quality Gate failed.
|
andrueastman
approved these changes
Oct 4, 2023
This was referenced Oct 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #429
This PR:
Org.OData.Core.V1.RequiresExplicitBindingbefore falling back on the containment check for the target navigation property.Org.OData.Core.V1.ExplicitOperationBindingswill need to be provided on the target navigation property with the said operation contained in the annotation collection for this method to be allowed.