This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Bring updates from master into temp/docs. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyw400
reviewed
Oct 20, 2018
| import pandas | ||
| from nimbusml import Pipeline | ||
| from nimbusml.feature_extraction.text import WordEmbedding | ||
| from nimbusml.feature_extraction.text import NGramFeaturizer |
Contributor
Author
There was a problem hiding this comment.
Apparently the tests passed with nimbusml.feature_extraction.text.ngramfeaturizer, but is it more correct to just say nimbusml.feature_extraction.text? If so, I'll change it in master as well. (These changes were just copied over from master.)
Contributor
Author
There was a problem hiding this comment.
@zyw400 Just wanted to check on this again. I'm happy to make the change in master if you think that is best.
Member
There was a problem hiding this comment.
I think that would be the best~~~
zyw400
approved these changes
Oct 20, 2018
Member
zyw400
left a comment
zyw400
left a comment
There was a problem hiding this comment.
Just revert one test change, else the build might fail. : )
ganik
added a commit
that referenced
this pull request
Dec 20, 2018
pieths
pushed a commit
to pieths/NimbusML
that referenced
this pull request
Sep 20, 2019
Latest updates to aml branch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I manually copied all the diffs from master into temp/docs. This was specifically needed because there were elements of the build script that were out of date and failing. From now on we should be able to merge updates to master into temp/docs and still be able to preserve the special underscore naming convention required by the official microsoft docs engine.