Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Linear SVM lambda parameter name should be public #254

@gregorybchris

Description

@gregorybchris

Describe the bug
The Linear SVM learner was recently added to NimbusML (version 1.3.0) and the parameter lambda, which is available as an optional regularization constant (called Lambda) for sweeping in ML.NET, is named lambda_ in NimbusML. This seems to imply that it is not part of the learner's public interface (or it was a typo).

To Reproduce
Steps to reproduce the behavior:

  1. Pass either lambda or lambda_ to the linear_model.LinearSvmBinaryClassifier constructor.

Expected behavior
The lambda parameter should be used to make it clear that sweeping this value is allowed from the public interface.

Enabling lambda as an optional parameter will be backward compatible since lambda_ should not have been used by any consumers of package versions 1.3.0 and 1.4.0.

Metadata

Metadata

Assignees

Labels

P1Needs to be fixed soon.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions