Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Conversation

@ant0nsc
Copy link
Contributor

@ant0nsc ant0nsc commented Mar 30, 2022

Title and activity bar red

@ant0nsc ant0nsc enabled auto-merge (squash) March 30, 2022 06:13
@ant0nsc ant0nsc requested review from Shruthi42 and fepegar March 30, 2022 07:39
Copy link
Contributor

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this?

@ant0nsc
Copy link
Contributor Author

ant0nsc commented Mar 30, 2022

@fepegar , it's relating to a discussion on Teams where I was saying that multiple VSCode windows for different repos are confusing, and it's easier to keep them apart if colored.

@fepegar
Copy link
Contributor

fepegar commented Mar 30, 2022

I see. Interesting! Can you please share a screenshot?

@ant0nsc
Copy link
Contributor Author

ant0nsc commented Mar 30, 2022

@fepegar , below is an example. Most importantly, the window colors are clearly visible in the window preview in the taskbar:
2022-03-30

Copy link
Contributor

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Copy link
Contributor

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think blue would make more sense than red? As red is typically used for errors.

@ant0nsc ant0nsc requested review from fepegar and mebristo April 2, 2022 17:26
fepegar
fepegar previously approved these changes Apr 2, 2022
mebristo
mebristo previously approved these changes Apr 4, 2022
@fepegar fepegar dismissed stale reviews from mebristo and themself via d97b947 April 4, 2022 15:40
@fepegar fepegar requested a review from mebristo April 4, 2022 15:41
@fepegar fepegar requested a review from javier-alvarez April 13, 2022 13:03
@ant0nsc ant0nsc merged commit c5b16e5 into main Apr 13, 2022
@ant0nsc ant0nsc deleted the antonsc/color branch April 13, 2022 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants