This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Fix for stuck Linux build: Move pytest to Windows #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c848bf6.
mebristo
reviewed
Feb 4, 2022
mebristo
approved these changes
Feb 4, 2022
| @pytest.mark.skipif(is_windows(), reason="cucim package is not available on Windows") | ||
| def test_load_roi(level: int, margin: int, foreground_threshold: Optional[float]) -> None: | ||
| dataset = MockSlidesDataset() | ||
| sample = dataset[0] |
There was a problem hiding this comment.
is this moving the tests to Windows and skipping them a temporary workaround?
skipping all tests related to cucim is a problem for the histo pipeline. For now these functions are used less frequently because they are used for patching and we store the patches. But if we want to move towards online patching this will prevent testing on the end-to-end pipeline
vale-salvatelli
approved these changes
Feb 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux PR build to run pytest got stuck after agent version upgrade. This PR changes pytest to run on Windows, apart from the tests that are Linux-specific.
Also renamed many build legs so that they can be found more easily in the UI.
Closes #651
Please follow the guidelines for PRs contained here. Checklist:
Added/Changed/Removed/... in the "Upcoming" section.
and if needed a motivation why that change was required.