Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Better handling of missing seriesId #488

Merged
merged 7 commits into from
Jun 10, 2021
Merged

Better handling of missing seriesId #488

merged 7 commits into from
Jun 10, 2021

Conversation

@JonathanTripp
Copy link
Contributor

@JonathanTripp JonathanTripp commented Jun 9, 2021 •
edited
Loading

  • if seriesId is missing from dataset.csv add it in as an empty string.

@JonathanTripp JonathanTripp self-assigned this Jun 9, 2021
@JonathanTripp JonathanTripp linked an issue Jun 9, 2021 that may be closed by this pull request
For cross validation on segmentation models, the seriesID column is mandatory, even though it is optional elsewhere #344
Closed
@JonathanTripp JonathanTripp marked this pull request as ready for review June 10, 2021 13:14
@JonathanTripp JonathanTripp merged commit 3557443 into main Jun 10, 2021
@JonathanTripp JonathanTripp deleted the jontri/series_ids branch June 10, 2021 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ant0nsc ant0nsc ant0nsc approved these changes

@Shruthi42 Shruthi42 Shruthi42 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JonathanTripp JonathanTripp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

For cross validation on segmentation models, the seriesID column is mandatory, even though it is optional elsewhere

3 participants

@JonathanTripp @ant0nsc @Shruthi42