Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Conversation

@JonathanTripp
Copy link
Contributor

@JonathanTripp JonathanTripp commented Jun 7, 2021

  • Add test that a boolean command line parameter is one of: 'on', 't', 'true', 'y', 'yes', '1' (for true) or 'off', 'f', 'false', 'n', 'no', '0' (for false) after lower()
  • If a flag default is False, then allow --flag to set it to True (so the ==True is unnecessary)
  • If a flag default is True, then allow --no-flag to set it to False (so the ==False is unnecessary)

@JonathanTripp JonathanTripp self-assigned this Jun 7, 2021
ant0nsc
ant0nsc previously approved these changes Jun 8, 2021
@JonathanTripp JonathanTripp requested a review from ant0nsc June 10, 2021 09:59
@JonathanTripp JonathanTripp merged commit 0f710dd into main Jun 10, 2021
@JonathanTripp JonathanTripp deleted the jontri/validate_bool branch June 10, 2021 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bool parameters like --train do not validate that the value is a bool

3 participants