Prevent usage of ':' in feature names. #95
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhilasharora
force-pushed
the
user/jimmyca/colonFeatureName
branch
from
890ab1a to
b638539
Compare
abhilasharora
force-pushed
the
user/jimmyca/colonFeatureName
branch
from
b638539 to
143441e
Compare
Member
|
Move to #288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilizing ':' in feature names causes problems due to how the .NET Core configuration system treats this character. This can lead to confusing situations when a developer tries to check whether a feature name that contains a ':' character is enabled.
This PR updates the
ConfigurationFeatureDefinitionProviderto throw anArgumentExceptionif ':' is passed in with a feature name to prevent developers from hitting these issues. Custom implementations ofIFeatureDefinitionProviderare free to support features with ':'.#90