Bug fix - Respect root configuration fallback #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the feature configuration fallback mechanism by ensuring that configuration sections are properly initialized only once.
- Adds a thread-safe lazy initialization method (EnsureInit) to load configuration sections when needed.
- Removes direct initialization of configuration sections from the constructor.
src/Microsoft.FeatureManagement/ConfigurationFeatureDefinitionProvider.cs
Show resolved
Hide resolved
Member
Author
|
Add a testcaste that fails before the fix and succeed after the fix |
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/bug-fix-4.2.0
branch
from
7eb0d2f to
92076c1
Compare
zhiyuanliang-ms
commented
Jul 2, 2025
jimmyca15
reviewed
Jul 2, 2025
src/Microsoft.FeatureManagement/ConfigurationFeatureDefinitionProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
approved these changes
Jul 7, 2025
zhiyuanliang-ms
added a commit
that referenced
this pull request
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
Fixed a bug introduced in 4.2.0: #546