Enhances FeatureManager to throw an exception for missing feature filters. #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r and the feature hasn't been registered, an exception will be thrown when the feature will be evaluated. (microsoft#13)
…thrown when a filter is missing.
zhenlan
reviewed
Feb 22, 2020
| { | ||
| /// <summary> | ||
| /// Controls the behavior of feature evaluation when dependent feature filters are missing. | ||
| /// If missing features filters are not ignored an exception will be thrown when attempting to evaluate a feature that depends on a missing feature filter. |
Member
Author
There was a problem hiding this comment.
Thanks ! I'll update before merge.
MSGaryWang
reviewed
Feb 24, 2020
| _logger = loggerFactory.CreateLogger<FeatureManager>(); | ||
| _filterMetadataCache = new ConcurrentDictionary<string, IFeatureFilterMetadata>(); | ||
| _contextualFeatureFilterCache = new ConcurrentDictionary<string, ContextualFeatureFilterEvaluator>(); | ||
| _options = options?.Value ?? throw new ArgumentNullException(nameof(options)); |
There was a problem hiding this comment.
options?.Value [](start = 23, length = 14)
so we don't expect a default value?
Member
Author
There was a problem hiding this comment.
The default value should be returned by Value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current feature manager implementation only logs a warning when a feature filter is missing for a given feature. This makes missing feature filters tricky to diagnose and can lead to unintended behavior. This enhancement changes the default behavior of the feature manager so that it will throw a
FeatureManagementExceptionwhen it encounters a missing feature filter.This new behavior can be disabled by configuring the feature management options.
This resolves #13
@codapus-co