-
Notifications
You must be signed in to change notification settings - Fork 119
Renames and updates EvaluationDataToAppInsights example #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 0 additions & 53 deletions
53
examples/EvaluationDataToApplicationInsights/HttpContextTargetingContextAccessor.cs
This file was deleted.
Oops, something went wrong.
4 changes: 0 additions & 4 deletions
4
examples/EvaluationDataToApplicationInsights/Pages/RandomizeUser.cshtml
This file was deleted.
Oops, something went wrong.
18 changes: 0 additions & 18 deletions
18
examples/EvaluationDataToApplicationInsights/Pages/RandomizeUser.cshtml.cs
This file was deleted.
Oops, something went wrong.
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
...licationInsights/Pages/Checkout.cshtml.cs → ...AndTelemetryDemo/Pages/Checkout.cshtml.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| @page | ||
| @model VariantAndTelemetryDemo.Pages.RandomizeUserModel | ||
| @{ | ||
| } |
30 changes: 30 additions & 0 deletions
30
examples/VariantAndTelemetryDemo/Pages/RandomizeUser.cshtml.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| using Microsoft.AspNetCore.Authentication; | ||
| using Microsoft.AspNetCore.Mvc; | ||
| using Microsoft.AspNetCore.Mvc.RazorPages; | ||
| using System.Security.Claims; | ||
|
|
||
| namespace VariantAndTelemetryDemo.Pages | ||
| { | ||
| public class RandomizeUserModel : PageModel | ||
| { | ||
| public IActionResult OnGet() | ||
| { | ||
| // Clear Application Insights cookies and | ||
| Response.Cookies.Delete("ai_user"); | ||
| Response.Cookies.Delete("ai_session"); | ||
|
|
||
| // Generate new user claim | ||
| var claims = new List<Claim> | ||
| { | ||
| new Claim(ClaimTypes.Name, Random.Shared.Next().ToString()) | ||
| }; | ||
|
|
||
| var identity = new ClaimsIdentity(claims, "CookieAuth"); | ||
| var principal = new ClaimsPrincipal(identity); | ||
|
|
||
| HttpContext.SignInAsync("CookieAuth", principal); | ||
|
|
||
| return RedirectToPage("/Index"); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
4 changes: 2 additions & 2 deletions
4
...icationInsights/Pages/_ViewImports.cshtml → ...ndTelemetryDemo/Pages/_ViewImports.cshtml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| @using EvaluationDataToApplicationInsights | ||
| @namespace EvaluationDataToApplicationInsights.Pages | ||
| @using VariantAndTelemetryDemo | ||
| @namespace VariantAndTelemetryDemo.Pages | ||
| @addTagHelper *, Microsoft.AspNetCore.Mvc.TagHelpers | ||
| @addTagHelper *, Microsoft.FeatureManagement.AspNetCore | ||
| @inject Microsoft.ApplicationInsights.AspNetCore.JavaScriptSnippet JavaScriptSnippet |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
...valuationDataToApplicationInsights.csproj → ...emetryDemo/VariantAndTelemetryDemo.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example is called
VariantAndTelemetryDemo. Can we use singular here for consistency if there is no grammer issue?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weirdly- I think the grammar makes sense. This is an app that has variants (plural). But when describing something as a demo- it doesn't need to be plural. Like FilterDemo (instead of FiltersDemo).
If others feel strongly to align the two- I'd prefer changing the package to
VariantsAndTelemetryDemo