Skip to content

Switching log from debug to warning #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Switching log from debug to warning #471

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e620f9
Switching log from debug to warning
rossgrambo Jul 9, 2024
bfdba17
Adjusted warning logs
rossgrambo Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.FeatureManagement.AspNetCore/TargetingHttpContextMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ public async Task InvokeAsync(HttpContext httpContext, ITargetingContextAccessor

if (activityFeature == null)
{
_logger.LogDebug("The IHttpActivityFeature from the IFeatureCollection was null");
_logger.LogWarning("A request feature required for telemetry, IHttpActivityFeature, was not found in the request's feature collection. Removing this feature from the request's feature collection will cause telemetry emission to fail.");
}
else if (activityFeature.Activity == null)
{
_logger.LogDebug("The Activity on the IHttpActivityFeature was null");
_logger.LogWarning("A request feature required for telemetry, IHttpActivityFeature, has a null Activity property. If you have updated IHttpActivityFeature, ensure the Activity property is not null. A missing Activity will result in telemetry emission failures.");
}
else
{
Expand Down