Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,7 @@ public Task<bool> EvaluateAsync(FeatureFilterEvaluationContext context)

if (settings.Value < 0)
{
if (_logger != null)
{
_logger.LogWarning($"The '{Alias}' feature filter does not have a valid '{nameof(settings.Value)}' value for feature '{context.FeatureName}'");
}
_logger?.LogWarning($"The '{Alias}' feature filter does not have a valid '{nameof(settings.Value)}' value for feature '{context.FeatureName}'");

result = false;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,7 @@ public Task<bool> EvaluateAsync(FeatureFilterEvaluationContext context)

if (!settings.Start.HasValue && !settings.End.HasValue)
{
if (_logger != null)
{
_logger.LogWarning($"The '{Alias}' feature filter is not valid for feature '{context.FeatureName}'. It must have have specify either '{nameof(settings.Start)}', '{nameof(settings.End)}', or both.");
}
_logger?.LogWarning($"The '{Alias}' feature filter is not valid for feature '{context.FeatureName}'. It must have have specify either '{nameof(settings.Start)}', '{nameof(settings.End)}', or both.");

return Task.FromResult(false);
}
Expand Down
5 changes: 1 addition & 4 deletions src/Microsoft.FeatureManagement/Targeting/TargetingFilter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,7 @@ public async Task<bool> EvaluateAsync(FeatureFilterEvaluationContext context)
// Ensure targeting can be performed
if (targetingContext == null)
{
if (_logger != null)
{
_logger.LogWarning("No targeting context available for targeting evaluation.");
}
_logger?.LogWarning("No targeting context available for targeting evaluation.");

return false;
}
Expand Down