Skip to content

Add a constructor without FeatureManagementOption parameter for FeatureManager #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Add a constructor without FeatureManagementOption parameter for FeatureManager #363

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b19e32
add new constructor
zhiyuanliang-ms Feb 2, 2024
0bd773f
update
zhiyuanliang-ms Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Microsoft.FeatureManagement/FeatureManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,14 @@ private class ConfigurationCacheItem
/// <param name="featureDefinitionProvider">The provider of feature flag definitions.</param>
/// <param name="options">Options controlling the behavior of the feature manager.</param>
/// <exception cref="ArgumentNullException">Thrown if <paramref name="featureDefinitionProvider"/> is null.</exception>
/// <exception cref="ArgumentNullException">Thrown if <paramref name="options"/> is null.</exception>
public FeatureManager(
IFeatureDefinitionProvider featureDefinitionProvider,
FeatureManagementOptions options)
FeatureManagementOptions options = null)
{
_filterMetadataCache = new ConcurrentDictionary<string, IFeatureFilterMetadata>();
_contextualFeatureFilterCache = new ConcurrentDictionary<string, ContextualFeatureFilterEvaluator>();
_featureDefinitionProvider = featureDefinitionProvider ?? throw new ArgumentNullException(nameof(featureDefinitionProvider));
_options = options ?? throw new ArgumentNullException(nameof(options));
_options = options ?? new FeatureManagementOptions();
_featureFilters = Enumerable.Empty<IFeatureFilterMetadata>();
_sessionManagers = Enumerable.Empty<ISessionManager>();
}
Expand Down