-
Notifications
You must be signed in to change notification settings - Fork 119
Fixed targeting assignment precedence. #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jimmyca15
merged 3 commits into
microsoft:feature/v3
from
jimmyca15:user/jimmyca/targetingPrecedence
May 25, 2022
Merged
Fixed targeting assignment precedence. #179
jimmyca15
merged 3 commits into
microsoft:feature/v3
from
jimmyca15:user/jimmyca/targetingPrecedence
May 25, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Please help with reviewing this PR if you can. |
avanigupta
reviewed
May 24, 2022
src/Microsoft.FeatureManagement/Targeting/ContextualTargetingFeatureVariantAssigner.cs
Show resolved
Hide resolved
avanigupta
reviewed
May 24, 2022
src/Microsoft.FeatureManagement/Targeting/ContextualTargetingFeatureVariantAssigner.cs
Show resolved
Hide resolved
avanigupta
reviewed
May 24, 2022
src/Microsoft.FeatureManagement/Targeting/ContextualTargetingFeatureVariantAssigner.cs
Outdated
Show resolved
Hide resolved
avanigupta
reviewed
May 24, 2022
src/Microsoft.FeatureManagement/Targeting/ContextualTargetingFeatureVariantAssigner.cs
Outdated
Show resolved
Hide resolved
avanigupta
reviewed
May 24, 2022
Member
avanigupta
reviewed
May 24, 2022
src/Microsoft.FeatureManagement/Targeting/ContextualTargetingFeatureVariantAssigner.cs
Show resolved
Hide resolved
Member
Author
That changes the logic. Currently, if any of the groups return a positive targeting result, then we return true. In reply to: 1136523253 Refers to: src/Microsoft.FeatureManagement/Targeting/TargetingEvaluator.cs:139 in 67b59b3. [](commit_id = 67b59b3, deletion_comment = False) |
avanigupta
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue regarding audience matching precedence when assigning variants via targeting.
If the current user is targeted by name directly, the associated variant should always win. This has the highest precedence.
Next is a group match.
Finally, if none of the above matches occur, default rollout percentage should be used to select a matching variant. Otherwise, the default variant should be selected.
This is already detailed in the README, but the existing code did not behave this way.