Allow for both IFeatureFilter and IContextualFeatureFilter with same alias #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this PR stuck because the tests are missing or is there something else? We recently also struggled with #98 and it would be nice if there was a solution. If it's just the tests maybe I could convince my employer to allow us to write them 🤔. |
Member
|
Move to this PR #262 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an opt-in mechanic to allow for having
IFeatureFilterandIContextualFeatureFilterwith the same alias. Specifically, you can have:0 or 1
IFeatureFilter0 or N
IContextualFeatureFilter<T>, so long as there is at most 1 applicable filter forT. So, you can have multiple contextual filters with the same alias, so long as they all handle discrete app contexts.By default, this functionality is disabled and can be enabled via
FeatureManagementOptions.AllowDuplicateContextualAlias.TODO:
Closes #98