Skip to content

Conversation

@jimmyca15
Copy link
Member

With the introduction of dynamic features, APIs were updated to distinguish between feature flags and dynamic features. As mentioned in #160 a few places were missed. This PR is a second pass to update spots that use "feature" where "feature flag" would be more appropriate.

@jimmyca15
Copy link
Member Author

cc @avanigupta @zhenlan are you able to take a look at this?

@zhenlan
Copy link
Member

zhenlan commented Feb 26, 2022

To customize the loading of feature definitions, one must implement the IFeatureFlagDefinitionProvider interface.

Do we want to say "feature flag definitions"?


Refers to: README.md:804 in 44a782d. [](commit_id = 44a782d, deletion_comment = False)

Copy link
Member

@zhenlan zhenlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jimmyca15
Copy link
Member Author

To customize the loading of feature definitions, one must implement the IFeatureFlagDefinitionProvider interface.

Do we want to say "feature flag definitions"?

Refers to: README.md:804 in 44a782d. [](commit_id = 44a782d, deletion_comment = False)

Yes, thanks.

@jimmyca15 jimmyca15 merged commit c816292 into microsoft:feature/v3 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants