Fix failing unit tests on Mac #384
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 9, 2024 09:57
Backslashes only work on Windows, but forward slashes are compatible with Windows, Mac, or Linux OSes. With change, TestLoadingConfigAndTryingToFetchManifest passes on Mac and Windows now.
Backslashes only work on Windows, but forward slashes are compatible with Windows, Mac, or Linux OSes. With change, TestRelationshipToDifferentNamespace passes on Mac and Windows now.
…bility. Mac and Linux OSes do not resolve backslashes. Normalizing the string before loading ensures that model path matches the resolved corpus path.
…bility. Mac and Linux OSes do not resolve backslashes. Normalizing the path before loading ensures that model path matches the resolved corpus path.
…bility. Mac and Linux OSes do not resolve backslashes or drive letters. Normalizing the path before testing ensures that adapter path matches the system path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of tests fail on Mac due to path format incompatibilities. These changes update tests and make them cross-platform compatible.