Skip to content

Add pre-chat message activity HTML test and removed starterPromptCar… #5477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 18, 2025
Merged

Add pre-chat message activity HTML test and removed starterPromptCar… #5477

merged 7 commits into from
Jul 18, 2025

Conversation

jcheung824
Copy link
Contributor

@jcheung824 jcheung824 commented May 13, 2025 •
edited by OEvgeny
Loading

ADO issue: https://msazure.visualstudio.com/CCI/_workitems/edit/32481620/

Description

  • Design expectation of having no starter prompt during blueprint state.

Design

https://www.figma.com/design/r8dKrVWy43ZFAMUQir2AgD/RS-Agent-Builder?node-id=3062-48739&m=dev

Specific Changes

  • Remove starter prompt card when the current ui state is blueprint state
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@jcheung824
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@jcheung824 jcheung824 force-pushed the jamescheung/bug-fix/remove-preview-loading-activities branch from 9d5c95b to 2525933 Compare July 17, 2025 00:21
OEvgeny
OEvgeny reviewed Jul 17, 2025
View reviewed changes
CHANGELOG.md Outdated
@@ -105,6 +105,7 @@ Notes: web developers are advised to use [`~` (tilde range)](https://github.com/

### Changed

- Removed `StarterPromptsCardAction` during `blueprint` ui state
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to mention author and PR, and put at the end of the list

OEvgeny
OEvgeny previously approved these changes Jul 17, 2025
View reviewed changes
compulim
compulim previously approved these changes Jul 17, 2025
View reviewed changes
@jcheung824 jcheung824 dismissed stale reviews from compulim and OEvgeny via b52e235 July 17, 2025 17:55
OEvgeny
OEvgeny previously approved these changes Jul 17, 2025
View reviewed changes
@OEvgeny OEvgeny enabled auto-merge (squash) July 17, 2025 18:39
auto-merge was automatically disabled July 17, 2025 21:55

Head branch was pushed to by a user without write access

OEvgeny
OEvgeny previously approved these changes Jul 17, 2025
View reviewed changes
@OEvgeny OEvgeny merged commit 5a404cf into microsoft:main Jul 18, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OEvgeny OEvgeny OEvgeny approved these changes

@compulim compulim compulim left review comments

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@beyackle2 beyackle2 Awaiting requested review from beyackle2 beyackle2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcheung824 @compulim @OEvgeny