Removed conn str and added exclude #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonWeber
approved these changes
May 18, 2023
lzchen
reviewed
May 19, 2023
| raise Exception("Hit an exception") | ||
|
|
||
|
|
||
| # Set the OTEL_PYTHON_EXCLUDE_URLS environment variable to "http://127.0.0.1:8000/exclude" |
Contributor
There was a problem hiding this comment.
Should add this env var to the README
Member
Author
There was a problem hiding this comment.
I guess we could. It's part of the instrumentation's readmes, but we did include it in the docs. There are other instrumentation related env vars I have not delt with much, so I think it would make sense to leave that for another PR where I add a whole section for instrumentation configuration env vars
lzchen
reviewed
May 19, 2023
|
|
||
| configure_azure_monitor( | ||
| connection_string="<your-connection-string>", | ||
| # connection_string="<your-connection-string>", |
Contributor
There was a problem hiding this comment.
What's the reason for this change?
Member
Author
There was a problem hiding this comment.
The distros are generally prioritizing the use of the conn str env var over pass ins. So, I made this change to match the distro docs. It also makes running the samples far less tedious.
lzchen
approved these changes
May 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update samples to rely on conn str env var. Updated samples that used to have instrumentation configs with env var instructions.