Skip to content

Allow SW scope without a trailing slash #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2024
Merged

Allow SW scope without a trailing slash #1184

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70b60e9
Allow SW scope without a trailing slash
microbit-matt-hillsdon May 30, 2024
010d014
Don't explode without BASE_URL
microbit-matt-hillsdon May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ export default defineConfig(({ mode }) => {
VitePWA({
disable: !featurePwa,
registerType: "autoUpdate",
// Remove the trailing slash so we can serve from e.g. /v/3 not just /v/3/
// This requires the corresponding service-worker-allowed header to be set.
// URLs are prefix matched so it's a compromise solution that could affect other
// paths sharing the same prefix
scope: process.env.BASE_URL?.replace(/\/$/, ""),
workbox: {
cacheId: pwaCacheId,
// Only precache language assets for the fallback language.
Expand Down