Skip to content

Conversation

@microbit-matt-hillsdon
Copy link
Collaborator

@microbit-matt-hillsdon microbit-matt-hillsdon commented Nov 12, 2023

Depends on review of

@github-actions
Copy link

Preview build will be at
https://review-python-editor-v3.microbit.org/translations/

@microbit-matt-hillsdon
Copy link
Collaborator Author

Just needs the UI testing when it rebuilds.

@microbit-matt-hillsdon microbit-matt-hillsdon marked this pull request as ready for review November 13, 2023 10:12
@microbit-matt-hillsdon
Copy link
Collaborator Author

Just needs the UI testing when it rebuilds.

Seems good!

@microbit-robert
Copy link
Collaborator

UI looks good. Minor comments on the related PRs - if no action is required then this is good to merge.

@microbit-matt-hillsdon
Copy link
Collaborator Author

UI looks good. Minor comments on the related PRs - if no action is required then this is good to merge.

Thanks - I've dealt with the feedback on those PRs and gone ahead and merged there and updated this PR. I'll merge this after reviewing the CI build.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 638f3ee into main Nov 13, 2023
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the translations branch November 13, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants