Upgrade to CodeMirror 6 release #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview build will be at |
microbit-robert
commented
Oct 5, 2022
microbit-robert
commented
Oct 5, 2022
microbit-robert
commented
Oct 5, 2022
microbit-robert
commented
Oct 5, 2022
microbit-robert
commented
Oct 5, 2022
Collaborator
Author
|
Leaving as a draft to avoid any accidental merge until we're happy we've tested this enough. |
Collaborator
Author
|
#798 remains an issue, so we can raise a CM bug (if we haven't already) once merged. |
Collaborator
|
There's a subtle code structure highlighting behaviour change that I think is worth looking at: New: Old: I think you could make a case for this being an improvement! |
Collaborator
|
I spent some more time testing this today and I'm happy. I'll deal with the conflict and tests for any interactions with #1037 then merge later this evening. |
This reverts commit 3cea9d9.
microbit-matt-hillsdon
force-pushed
the
upgrade-codemirror
branch
from
ded9a02 to
3cc2899
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #995.
Closes #753.
Closes #697.
Closes #612.
Closes #716.