Allow setting analog period on pins #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for distracted-dubinsky-fd8a42 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| // attempt to configure the pin in analog-out mode by calling setAnalogValue. | ||
| if ((ErrorCode)pin_obj[pin]->getAnalogPeriodUs() == DEVICE_NOT_SUPPORTED) { | ||
| if (pin_obj[pin]->setAnalogValue(0) != DEVICE_OK) { | ||
| return -1; |
There was a problem hiding this comment.
No matter what I do I can't get this or the error branch below to trigger on a V2 device. So for now, the simulator calls always succeed.
@dpgeorge do you know how I can trigger these error branches?
Link to easier to read version: https://github.com/microbit-foundation/micropython-microbit-v2/blob/e4321a866e3f8ef48a7f5b5e96db99cc39b09757/src/codal_app/microbithal.cpp#L155
microbit-matt-hillsdon
force-pushed
the
pin-period
branch
from
9955951 to
1fe25d2
Compare
|
Main risk for review is probably that I'll break the existing pin support. |
microbit-robert
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the servo scenario on #76