Fix audio bug on simulator soft reboot #71
Conversation
✅ Deploy Preview for distracted-dubinsky-fd8a42 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| if (this.context) { | ||
| this.context.close(); | ||
| this.context = undefined; | ||
| this.oscillator = undefined; | ||
| } |
There was a problem hiding this comment.
Previously thrown away when the board was stopped, but not re-initialised on a soft reboot. This is now thrown away when stop() is called.
There was a problem hiding this comment.
Can this mean we keep playing sounds? Would it be better to close/reinit the audio?
There was a problem hiding this comment.
This doesn't appear to be the case. It may be safer, but we need to find a way to pass wrapped._microbit_hal_audio_ready_callback and wrapped._microbit_hal_audio_speech_ready_callback into an init function that is called on a soft reboot.
There was a problem hiding this comment.
I'm fine with this approach if there aren't practical issues. It might be safer in other ways as the audio context creation will always tied to a user event so less likely to hit browser issues.
Closes #70.