Don't generate empty argument objects #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mghoneimy I've tried this change on my code base and it removes a large amount of useless classes. |
jorrit
force-pushed
the
noemptyargs
branch
5 times, most recently
from
a1f9a1b to
5d8684d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a fairly large API and as such a lot of PHP files are generated by the OQM code generator.
Most of the field in my schema have no arguments, but right now the OQM generates an empty
ArgumentsObjectclass for each object field.This PR enhances the code generator so an ArgumentsObject is only generated when a field accepts arguments.