Pass tests on Windows; #2
Conversation
Skipped testUnwritableDirInConstructor(), testUnwritableDir() on Windows;
| * @param $filename | ||
| * @return string | ||
| */ | ||
| private function readFileContent($filename) { |
There was a problem hiding this comment.
I think renaming this to readFileContentWithoutWhitespaces makes more sense
| return false; | ||
| } | ||
|
|
||
| if (strcmp($expected, $generated) !== 0) { |
There was a problem hiding this comment.
I think that we should assert that one string is not empty then that the 2 strings are equal instead of returning values. The method should call an assertion internally rather than returning a value that we would call an assertion against later.
|
|
||
| $expected = $this->readFileContent($expectedFile); | ||
|
|
||
| if (empty($expected)) { |
|
|
||
| $generated = $this->readFileContent($actualFile); | ||
|
|
||
| if (empty($generated)) { |
| $this->codeFile->writeFile(); | ||
|
|
||
| $this->assertFileEquals(static::getExpectedFilesDir() . "/$this->fileName.php", $this->codeFile->getWritePath()); | ||
| $this->assertTrue( |
There was a problem hiding this comment.
Ideally, we should just call the assertion method. Not call an assertion inside an assertion.
| $this->assertFileEquals( | ||
| static::getExpectedFilesDir() . "/$objectName.php", | ||
| static::getGeneratedFilesDir() . "/$objectName.php" | ||
| $this->assertTrue( |
There was a problem hiding this comment.
same in all instances that have the same issue, we should remove the assertTrue
| $this->queryObject = new SimpleQueryObject('simples'); | ||
| } | ||
|
|
||
| private function replaceWhitespace(string $string) { |
There was a problem hiding this comment.
I would prefer if you replace the method with an assertion, something like assertStringsEqualWithoutWhitespaces and apply that assertion to all assertions in this class.
2 participants
The problem is coming from php-graphql-client
FieldTrait.php constructSelectionSet()where we use a\ncharacter to build the query.I fixed it and other Windows specified problems in the tests for php-graphql-oqm.
A new line on Windows is
\r\n, linux\ntestUnwritableDirInConstructor(), testUnwritableDir() - we need to skip these tests, because windows don't have chmod().
DIRECTORY_SEPARATOR - depending on a platform
/or\The test results on win7 x64 PHP 7.3.9 MINGW64
vendor/phpunit/phpunit/phpunit tests/ --whitelist src/ --coverage-clover build/coverage/xml
Tests with this PR on win7 x64 PHP 7.3.9 MINGW64