Skip to content
This repository was archived by the owner on May 16, 2025. It is now read-only.

Conversation

@fsteeg
Copy link
Member

@fsteeg fsteeg commented Apr 14, 2020

Perform .editorconfig and checkstyle.xml checks in ./gradlew check.

blackwinter and others added 11 commits March 17, 2020 16:47
- Central version configuration
- Formatting (sorting/grouping)
- Indentation: TAB = 2 * SPC
Based on https://github.com/metafacture/metafacture-core/tree/metafacture-core-3.5.0/quality_assurance.

Added checks/filters:

- AvoidNestedBlocks
- AvoidNoArgumentSuperConstructorCall
- AvoidStarImport
- AvoidStaticImport (debatable)
- CatchParameterName
- CustomImportOrder
- EmptyLineSeparator
- GenericWhitespace
- HiddenField
- Indentation
- InnerTypeLast (debatable)
- InterfaceTypeParameterName
- LambdaParameterName
- LeftCurly
- MethodParamPad
- MissingCtor (debatable)
- NeedBraces
- NoArrayTrailingComma
- NoEnumTrailingComma
- NoWhitespaceAfter
- NoWhitespaceBefore
- OneStatementPerLine
- OneTopLevelClass
- OperatorWrap
- OuterTypeFilename
- OuterTypeNumber
- OverloadMethodsDeclarationOrder
- ParenPad
- RedundantImport
- RequireThis
- RightCurly
- SeparatorWrap
- SuppressWarnings
- SuppressWithNearbyCommentFilter
- TypecastParenPad
- UnnecessarySemicolonAfterTypeMemberDeclaration
- UnnecessarySemicolonInEnumeration
- UnnecessarySemicolonInTryWithResources
- UnusedImports
- UpperEll
- WhitespaceAfter
- WhitespaceAround

Dropped checks/filters:

- ArrayTrailingComma (personal preference)
- AvoidInlineConditionals (personal preference)
- DesignForExtension (personal preference)
- FileContentsHolder (removed in 8.2)
- FinalClass (personal preference)
- Header (unused atm)
- IllegalInstantiation (not configured)
- IllegalTokenText (not configured)
- JUnitTestCase (removed in 6.2)
- RedundantThrows (removed in 6.2)
- Regexp (not configured)
- StrictDuplicateCode (removed in 6.2)
- SuppressWithNearbyCommentFilter (unused atm)
- SuppressionCommentFilter (unused atm)
- SuppressionFilter (replaced with SuppressionSingleFilter)
- Remove Eclipse config that is generated during Gradle import
- Add Eclipse generated directories to EditorConfig exclusions
- Set up .checkstyle Eclipse config pointing to checkstyle.xml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants