Skip to content

Enforce unique result in list-fix-paths #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 1, 2025
Merged

Enforce unique result in list-fix-paths #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f9a097
Enforce unique result #686
TobiasNx Apr 25, 2025
6a4f548
Adjust tests to check duplicate elements/values in multiple records #686
TobiasNx Jun 20, 2025
67a7e6e
Restore `Mockito.verifyNoMoreInteractions(receiver)` test (#687)
fsteeg Jul 14, 2025
f5b49fb
Tweak test to actually require added `TripleSort` to pass (#686)
fsteeg Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion metafix/src/main/java/org/metafacture/metafix/FindFixPaths.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,12 @@
import org.metafacture.framework.annotations.In;
import org.metafacture.framework.annotations.Out;
import org.metafacture.framework.helpers.DefaultStreamPipe;
import org.metafacture.mangling.DuplicateObjectFilter;
import org.metafacture.mangling.StreamFlattener;
import org.metafacture.triples.AbstractTripleSort.Compare;
import org.metafacture.triples.StreamToTriples;
import org.metafacture.triples.TripleFilter;
import org.metafacture.triples.TripleSort;

import java.io.IOException;

Expand All @@ -37,7 +40,7 @@
*
* @author Tobias Bülte
*/
@Description("Finds all paths that have values that match the given pattern. Allows for regex. These paths can be used in a Fix to address fields.")
@Description("Finds all paths that have values that match the given pattern. Allows for regex. These paths can be used in a Fix to address fields.") // checkstyle-disable-line ClassDataAbstractionCoupling
@In(StreamReceiver.class)
@Out(String.class)
@FluxCommand("find-fix-paths")
Expand Down Expand Up @@ -67,11 +70,15 @@ public FindFixPaths(final String objectPattern) {
protected void onSetReceiver() {
final TripleFilter tripleFilter = new TripleFilter();
tripleFilter.setObjectPattern(objectPattern);
final TripleSort tripleSort = new TripleSort();
tripleSort.setBy(Compare.PREDICATE);
fix
.setReceiver(new StreamFlattener())
.setReceiver(new StreamToTriples())
.setReceiver(tripleFilter)
.setReceiver(tripleSort)
.setReceiver(new ObjectTemplate<>("${p}\t|\t${o}"))
.setReceiver(new DuplicateObjectFilter<>())
.setReceiver(getReceiver());
}

Expand Down
11 changes: 10 additions & 1 deletion metafix/src/test/java/org/metafacture/metafix/FindFixPathsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,19 +47,28 @@ public FindFixPathsTest() {
public void testShouldFindPaths() {
verify(
"a\t|\tAn ETL test",
"a\t|\tAnother ETL test",
"c.2\t|\tETL what?");
}

private void processRecord() {
finder.setReceiver(receiver);
finder.startRecord("");
finder.startRecord("1");
finder.literal("a", "An ETL test");
finder.literal("b", "");
finder.literal("b", "Dummi");
finder.literal("b", "Dog");
finder.literal("c", "");
finder.literal("c", "ETL what?");
finder.endRecord();
finder.startRecord("2");
finder.literal("a", "Another ETL test");
finder.literal("b", "");
finder.literal("b", "Dummi");
finder.literal("b", "Dog");
finder.literal("c", "");
finder.literal("c", "ETL what?");
finder.endRecord();
finder.closeStream();
}

Expand Down