Skip to content

Conversation

@blackwinter
Copy link
Member

Based off of JSON module. But not every feature of the JSON implementation can be (easily/reasonably) supported in the YAML implementation (decoder: optional comments, JsonPath; encoder: root value separator, (optional) pretty printing).

Maybe there's room for consolidation, though, with YAML being a superset of JSON. Both pairs of classes could (should?) have a common superclass implementing the actual decoding/encoding.

Fixes #399.

Based off of JSON module.

Fixes #399.
@dr0i dr0i removed the request for review from fsteeg October 4, 2021 10:24
@dr0i dr0i unassigned fsteeg Oct 4, 2021
@acka47
Copy link
Contributor

acka47 commented Oct 8, 2021

@blackwinter please merge

@blackwinter
Copy link
Member Author

So we're not going to discuss the intrinsic relationship between the two modules? Are we content with the duplication?

@dr0i
Copy link
Member

dr0i commented Oct 8, 2021

@acka47 acka47 requested a review from fsteeg October 8, 2021 10:23
@acka47
Copy link
Contributor

acka47 commented Oct 8, 2021

So we're not going to discuss the intrinsic relationship between the two modules? Are we content with the duplication?

You are right. We got confused about where we are in the process. @fsteeg will review.

Copy link
Member

@fsteeg fsteeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, YAML support, many thanks! I think the partial duplication of the JSON module is fine, we can always extract a superclass later, when/if we see that we're actually building/fixing stuff in both modules.

@fsteeg fsteeg assigned blackwinter and unassigned fsteeg Oct 14, 2021
@blackwinter
Copy link
Member Author

we can always extract a superclass later, when/if we see that we're actually building/fixing stuff in both modules.

Well, let's hope we don't forget... 🙂

@blackwinter blackwinter merged commit 478c6cb into master Oct 14, 2021
@blackwinter blackwinter deleted the 399-implementYamlModule branch October 14, 2021 09:27
@fsteeg
Copy link
Member

fsteeg commented Oct 14, 2021

Well, let's hope we don't forget... 🙂

One could argue that we should wait for supporting a third JSON-like format before we even consider extracting it: https://en.wikipedia.org/wiki/Rule_of_three_(computer_programming)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suppot yaml (encoding/decoding)

5 participants