-
Notifications
You must be signed in to change notification settings - Fork 33
Enable RestMap and deliver test #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
philboeselager
wants to merge
3
commits into
metafacture:master
from
philboeselager:lobid-organisations/#issue49
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
src/test/java/org/culturegraph/mf/morph/maps/RestMapTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package org.culturegraph.mf.morph.maps; | ||
|
|
||
| import static org.junit.Assert.assertTrue; | ||
|
|
||
| import java.io.IOException; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| /** | ||
| * Tests {@link RestMap}. | ||
| * | ||
| * @author Philipp v. Böselager | ||
| * | ||
| */ | ||
| public final class RestMapTest { | ||
|
|
||
| private static final String BASE_URL_01 = "http://beta.lobid.org/${key}"; | ||
| private static final String TEST_CASE_01 = "organisations/DE-6#!"; | ||
|
|
||
| @Test | ||
| public void testGetDatasource() throws IOException { | ||
| final RestMap map = new RestMap(); | ||
| map.setUrl(BASE_URL_01); | ||
| String result = map.get(TEST_CASE_01); | ||
| assertTrue(result.contains("51.96286")); | ||
| } | ||
|
|
||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the
url.replace(" ", "%20")necessary here? The test data does not seem to contain a space, or am I misunderstanding something?If in general characters that need encoding should be supported here, wouldn't a general approach like calling
URLEncoder.encode(String s, String enc)withkey.toString()when building the URL be safer?And can we get rid of the
.toASCIIString()to support keys likeorganisations?q=Köln, if that makes any sense?