Skip to content

Remove unused ManagedCollisionCollection._create_feature_order #3400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+0 −12
Closed

Remove unused ManagedCollisionCollection._create_feature_order #3400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions torchrec/modules/mc_modules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,18 +371,6 @@ def __init__(
self._created_feature_order: List[bool] = [False]
self._features_order = []

def _create_feature_order(
self,
input_feature_names: List[str],
device: torch.device,
) -> None:
features_order: List[int] = []
for f in self._feature_names:
features_order.append(input_feature_names.index(f))

if features_order != list(range(len(features_order))):
self._features_order = features_order

def embedding_configs(self) -> Sequence[BaseEmbeddingConfig]:
return self._embedding_configs

Expand Down
Loading