Skip to content

Clean up setting of env vars in client_bootstrap.sh #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clean up setting of env vars in client_bootstrap.sh #596

wants to merge 1 commit into from

Conversation

@daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Nov 19, 2025

These env vars are already set in launcher.py

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 19, 2025
@JenniferWang
Copy link
Contributor

JenniferWang commented Nov 20, 2025 •
edited
Loading

Could you add the Test Plan?
Assuming that you've tested it with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JenniferWang JenniferWang JenniferWang approved these changes

@allenwang28 allenwang28 Awaiting requested review from allenwang28

@Ritesh1905 Ritesh1905 Awaiting requested review from Ritesh1905

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daniellepintz @JenniferWang