improve error msg of invalid input types #1083
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekmig
approved these changes
Dec 6, 2022
Contributor
vivekmig
left a comment
vivekmig
left a comment
There was a problem hiding this comment.
Looks good!
nit: Seems like it might be necessary to run ufmt from the CircleCI results?
Contributor
|
Conda started failing since yesterday but for ci/circleci: test_py37_conda only and there is a small formatting issue. |
Contributor
Author
|
@NarineK I will try to solve the conda issue in another pr |
Contributor
|
@aobo-y has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #1077 (comment) , improving the error message of invalid
inputsto tell the two types we allow:Tensorandtuple[Tensor]