-
Notifications
You must be signed in to change notification settings - Fork 115
[CI] Comment on new env PRs #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zkwentz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed your changes atop #160. Looks good.
One thought: in the comment can we note the preferred flow, something like:
Your env passes the vibe check. However, most environments should go straight to the hub, they will automatically be added to the official Env Hub collection on a nightly basis. Environments in the official specification repo are only meant to demonstrate usage of a specific spec feature for educational purposes.
zkwentz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gucci
[CI] Comment on new env PRs
This PR update the CI for new PRs on envs. It does two things:
Here is a succesful comment on a fork pr.
validatecommand.