Skip to content

Fix support for HTTP request with methods other than GET and POST. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Fix support for HTTP request with methods other than GET and POST. #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions messagebird/http_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import json
import requests

try:
Expand Down Expand Up @@ -28,14 +29,22 @@ def request(self, path, method='GET', params=None):
'Content-Type': 'application/json'
}

if method == 'GET':
if method == 'DELETE':
response = requests.delete(url, verify=True, headers=headers, data=json.dumps(params))
elif method == 'GET':
response = requests.get(url, verify=True, headers=headers, params=params)
else:
elif method == 'PATCH':
response = requests.patch(url, verify=True, headers=headers, data=json.dumps(params))
elif method == 'POST':
response = requests.post(url, verify=True, headers=headers, data=json.dumps(params))
elif method == 'PUT':
response = requests.put(url, verify=True, headers=headers, data=json.dumps(params))
else:
raise ValueError(str(method) + ' is not a supported HTTP method')

if response.status_code in self.__supported_status_codes:
response_text = response.text
else:
response.raise_for_status()

return response_text
return response_text