Fix Python 3 compatibility issues #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Python classifiers to setup.py to include Python, Python 2 and Python 3. For more information about classifiers see: https://www.python.org/dev/peps/pep-0301/#distutils-trove-classification
In Python 3 `items()` return iterators, and a list is never fully build. The `items()` method in Python 3 works like `viewitems()` in Python 2.7. For more information see: https://docs.python.org/3/whatsnew/3.0.html#views-and-iterators-instead-of-lists
Update print to function in `examples/message_create.py`. The `print` statement becomes the `print()` function in Python 3.
|
Hi @roaldnefs, thanks for submitting this pull request! Can you confirm this is not a breaking change? |
Yes, I can confirm that. I've tested the changes locally using Python 3.6 and Python 2.7. |
|
@roaldnefs Great, thank you! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Python 3 compatibility, the following issues were found using 2to3:
dict.items()inmessagebird/base.py.printstatement inexamples/message_create.py.This PR also adds the classifiers to
setup.pyin order to add the 'Programming Language' to the Messagebird PyPi project page.