Use the JSON formatter from Scala library and removed dependency on lift-json. #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ift-json. It made the JSON creation slightly more complicated, but reduces one external dependency. The scala library also properly escape "/" (which lift-json doesn't).
Contributor
|
Okay this looks good - did you test it in a browser and just make sure everything renders OK? |
Contributor
There was a problem hiding this comment.
This and a few other things look like they were added. Did you mean to do this?
Contributor
There was a problem hiding this comment.
Ah nvm, I see the other PR.
Contributor
|
Ya looks good to me. |
rxin
added a commit
that referenced
this pull request
Aug 16, 2013
Use the JSON formatter from Scala library and removed dependency on lift-json.
|
Thank you for submitting this pull request. All automated tests for this request have passed. Refer to this link for build results: http://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/616/ |
xiajunluan
pushed a commit
to xiajunluan/spark
that referenced
this pull request
May 30, 2014
Author: Kan Zhang <[email protected]> Closes mesos#841 from kanzhang/SPARK-1822 and squashes the following commits: 2f8072a [Kan Zhang] [SPARK-1822] Minor style update cf4baa4 [Kan Zhang] [SPARK-1822] Adding Scaladoc e67c910 [Kan Zhang] [SPARK-1822] SchemaRDD.count() should use optimizer
xiajunluan
pushed a commit
to xiajunluan/spark
that referenced
this pull request
May 30, 2014
Minor cleanup following mesos#841. Author: Reynold Xin <[email protected]> Closes mesos#868 from rxin/schema-count and squashes the following commits: 5442651 [Reynold Xin] SPARK-1822: Some minor cleanup work on SchemaRDD.count()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It made the JSON creation slightly more complicated, but reduces one external dependency. The scala library also properly escape "/" (which lift-json doesn't).
This subsumes #834.