Move JavaAPISuite into spark.streaming. #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Weird; it's definitely run for me, but maybe it depends on whether you use Maven or SBT. Which one did you use? In any case it's okay to move it. |
Contributor
Author
|
Eclipse was complaining about it. I didn't try the command line. I believe being in the root package would be fine, but the JavaAPISuite.java had a "package spark.streaming" at the top of it, which isn't technically Java spec, but perhaps Maven/SBT don't care. I was considering removing the "package spark.streaming", but it looked like other projects in the repo had their JavaAPISuite in a non-root package, so followed suit. |
mateiz
added a commit
that referenced
this pull request
Jan 21, 2013
Move JavaAPISuite into spark.streaming.
Member
|
No, it's good to move it. Thanks for the clarification. |
harveyfeng
pushed a commit
to harveyfeng/spark-mesos
that referenced
this pull request
Jan 14, 2014
Stop SparkListenerBus daemon thread when DAGScheduler is stopped. Otherwise this leads to hundreds of SparkListenerBus daemon threads in our unit tests (and also problematic if user applications launches multiple SparkContext).
harveyfeng
pushed a commit
to harveyfeng/spark-mesos
that referenced
this pull request
Jan 14, 2014
Better error handling in Spark Streaming and more API cleanup Earlier errors in jobs generated by Spark Streaming (or in the generation of jobs) could not be caught from the main driver thread (i.e. the thread that called StreamingContext.start()) as it would be thrown in different threads. With this change, after `ssc.start`, one can call `ssc.awaitTermination()` which will be block until the ssc is closed, or there is an exception. This makes it easier to debug. This change also adds ssc.stop(<stop-spark-context>) where you can stop StreamingContext without stopping the SparkContext. Also fixes the bug that came up with PRs mesos#393 and mesos#381. MetadataCleaner default value has been changed from 3500 to -1 for normal SparkContext and 3600 when creating a StreamingContext. Also, updated StreamingListenerBus with changes similar to SparkListenerBus in mesos#392. And changed a lot of protected[streaming] to private[streaming].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that on master JavaAPISuite wasn't compiling for me because it seemed to be in the wrong location.