[WC-3047] Gallery: Improve preview with limited rows and fade out #1833
+127
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjulivan
reviewed
Aug 15, 2025
gjulivan
reviewed
Aug 15, 2025
r0b1n
reviewed
Aug 27, 2025
r0b1n
reviewed
Aug 27, 2025
packages/pluggableWidgets/gallery-web/src/features/useGridPositionsPreview.ts
Outdated
Show resolved
Hide resolved
r0b1n
reviewed
Aug 27, 2025
packages/pluggableWidgets/gallery-web/src/features/useGridPositionsPreview.ts
Outdated
Show resolved
Hide resolved
yordan-st
force-pushed
the
fix/WC-2924_gallery-preview-columns
branch
2 times, most recently
from
c863e67 to
78dd7b2
Compare
r0b1n
previously approved these changes
Sep 1, 2025
leonardomendix
previously approved these changes
Sep 4, 2025
gjulivan
previously approved these changes
Sep 4, 2025
leonardomendix
previously approved these changes
Sep 4, 2025
gjulivan
dismissed stale reviews from leonardomendix and themself
via
c35dc33
gjulivan
force-pushed
the
fix/WC-2924_gallery-preview-columns
branch
from
7f303c4 to
c35dc33
Compare
gjulivan
force-pushed
the
fix/WC-2924_gallery-preview-columns
branch
from
c35dc33 to
66d4843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Fixed an issue where the displayed number of columns in preview mode wouldn't match the configuration
Added functionality where the row count doesn't exceed 3 - in cases where it should because of the column count x page size
Added functionality where the rows of the widget slowly fade out in a vertical gradient
What should be covered while testing?
If the rows in no circumstance exceed the count of 3.
Therefore configure a page size and column count which would normally cause the row count to exceed 3.
Test this on al viewports
Test if there is a fade-away gradient overlaying the grid items