Skip to content

[MOO-1997] Fix Safe Area #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2025
Merged

[MOO-1997] Fix Safe Area #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d7c0a0
fix: the safe area view by changing layout of views
stelselim Aug 6, 2025
7e7df6c
fix: update docs
stelselim Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/safe-area-view-native/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

- We fixed the issue where navigation buttons were being overlapped due to improper safe area handling.

## [3.1.0] - 2025-4-25

- We fixed the issue where the header is going outside of page in some android versions.

## [3.0.1] - 2025-3-18
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/safe-area-view-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "safe-area-view-native",
"widgetName": "SafeAreaView",
"version": "3.1.0",
"version": "3.1.1",
"license": "Apache-2.0",
"repository": {
"type": "git",
Expand Down
29 changes: 7 additions & 22 deletions packages/pluggableWidgets/safe-area-view-native/src/SafeAreaView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,33 +3,18 @@ import { flattenStyles } from "@mendix/piw-native-utils-internal";
import { SafeAreaViewStyle, defaultSafeAreaViewStyle } from "./ui/Styles";
import { SafeAreaViewProps } from "../typings/SafeAreaViewProps";
import { SafeAreaView as SafeAreaViewComponent } from "react-native-safe-area-context";
import { useBottomTabBarHeight } from "@react-navigation/bottom-tabs";
import { View } from "react-native";

export function useSafeBottomTabBarHeight(): number {
try {
const height = useBottomTabBarHeight();
return height;
} catch (e) {
return 0;
}
}

export const SafeAreaView = (props: SafeAreaViewProps<SafeAreaViewStyle>): JSX.Element => {
const styles = flattenStyles(defaultSafeAreaViewStyle, props.style);
const tabBarHeight = useSafeBottomTabBarHeight();

const isBottomBarActive = tabBarHeight > 0;
return (
<SafeAreaViewComponent
edges={isBottomBarActive ? ["top", "left", "right"] : undefined}
style={{ flex: 1, ...{ backgroundColor: styles.container.backgroundColor } }}
pointerEvents={"box-none"}
testID={props.name}
>
<View style={styles.container} pointerEvents={"box-none"}>
{props.content}
</View>
</SafeAreaViewComponent>
<View style={{ flex: 1, backgroundColor: styles.container.backgroundColor }}>
<SafeAreaViewComponent style={{ flex: 1 }} pointerEvents={"box-none"} testID={props.name}>
<View style={styles.container} pointerEvents={"box-none"}>
{props.content}
</View>
</SafeAreaViewComponent>
</View>
);
};
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/safe-area-view-native/src/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="SafeAreaView" version="3.1.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="SafeAreaView" version="3.1.1" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="SafeAreaView.xml" />
</widgetFiles>
Expand Down