Skip to content

Conversation

@curquiza
Copy link
Member

@curquiza curquiza commented Oct 8, 2020

⚠️ Git does not make things easy to review at all, maybe check the test file directly

Here are what I did:

  • Add missing tests in unit tests configuration
  • Move the global settings tests at the end of the file
  • Make class variable to avoid repetition
  • Add attributesForFaceting in the Settings struct
  • The settings tests for the get methods (ex: getRankingRules) only call the get method. No need to update settings to test the settings fetch, we can check we get the default values
  • Make the settings tests for the update method (ex: updateRankingRules) simplier: no need to check two updates in the same tests. It make things harder to maintain and to read.

@curquiza curquiza requested review from bidoubiwa and ppamorim October 8, 2020 14:09
@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Oct 8, 2020
@curquiza curquiza merged commit 7f3c1a4 into feature/integrationTest Oct 8, 2020
@curquiza curquiza deleted the upd-test branch October 8, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants