Remove acceptNewFields routes #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up Setting struct and added default values for attributes. Added UT for testing default values. Removed "distinctAttributes" from JSON test payload. Signed-off-by: Damien Rivet <[email protected]>
Closed
damien-rivet
changed the title
ppamorim
reviewed
Oct 3, 2020
Removed unneeded Setting initializer.
ppamorim
previously approved these changes
Oct 3, 2020
Contributor
|
@curquiza Could you please review and merge if approved? |
bidoubiwa
reviewed
Oct 5, 2020
Contributor
bidoubiwa
left a comment
bidoubiwa
left a comment
There was a problem hiding this comment.
Thanks a lot for this contribution! It's a really good work :)
Restored all explicit types which were removed previously. Added missing Linux test for Settings. Signed-off-by: Damien Rivet <[email protected]>
Contributor
Author
|
Just FYI, I had to reword my last commit since the build failed to restart the build. And without changing anything, the build completed successfully this time, the failing test was |
24 tasks
Contributor
|
@Ethenyl Thank you very much, we really appreciate your effort in this PR. Regarding the failing |
ppamorim
approved these changes
Oct 5, 2020
curquiza
approved these changes
Oct 5, 2020
curquiza
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #48.
Remove
acceptNewFieldsroutes and add default values forsearchableAttributesanddisplayedAttributesinSettings.Miscellaneous
Added UT for testing default values and removed
distinctAttributesfrom JSON test payload.