Tasks changes #315
Merged
Tasks changes #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
force-pushed
the
tasks-changes
branch
from
c84b9f7 to
371dd1f
Compare
bidoubiwa
reviewed
Aug 3, 2022
| self.tasks.waitForTask(task: task, options: options, completion) | ||
| } | ||
|
|
||
| public func waitForTask( |
Contributor
There was a problem hiding this comment.
I think you forgot to a comment above explaining the function and its parameters
Member
Author
There was a problem hiding this comment.
All the descriptions of the new classes/types/methods will be done after these PRs being merged :)
Comment on lines
+25
to
+27
| "type": types.isEmpty ? nil : types.joined(separator: ","), | ||
| "status": status.isEmpty ? nil : status.joined(separator: ","), | ||
| "indexUid": indexUid.isEmpty ? nil : indexUid.joined(separator: ",") |
Contributor
There was a problem hiding this comment.
Is this ternary useful since you are safe guarding above?
Member
Author
There was a problem hiding this comment.
After your suggestion I had to change to this: "indexUid": indexUid != nil ? indexUid?.joined(separator: ",") : nil
Contributor
|
🔒 Permission denied Existing reviewers: click here to make bidoubiwa a reviewer |
This was referenced Aug 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TasksQueryto handle query string for /tasks callsTasksResultstype to handle the object response in the GET /tasks response.