meilisearch · brunoocasali · Aug 9, 2022 · Apr 27, 2022 · Apr 27, 2022 · Aug 4, 2022
diff --git a/.github/workflows/pre-release-tests.yml b/.github/workflows/pre-release-tests.yml
@@ -9,9 +9,12 @@ on:
     branches: [bump-meilisearch-v*]
 
 jobs:
-  integeration_tests:
-    name: integration-tests
-    runs-on: macos-11
+  integration_tests:
+    name: integration-tests on ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: ["macos-latest", "ubuntu-20.04"]
     env:
       DEVELOPER_DIR: /Applications/Xcode_12.4.app/Contents/Developer
     steps:

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -10,12 +10,15 @@ on:
       - main
 
 jobs:
-  integeration_tests:
+  integration_tests:
     # Will not run if the event is a PR to bump-meilisearch-v* (so a pre-release PR)
     # Will still run for each push to bump-meilisearch-v*
     if: github.event_name != 'pull_request' || !startsWith(github.base_ref, 'bump-meilisearch-v')
-    name: integration-tests
-    runs-on: macos-latest
+    name: integration-tests on ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: ["macos-latest", "ubuntu-20.04"]
     env:
       DEVELOPER_DIR: /Applications/Xcode_12.4.app/Contents/Developer
       GITHUB_PAT: ${{ secrets.MEILIBOT_PAT_REPO }}

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -30,6 +30,16 @@ First of all, thank you for contributing to Meilisearch! The goal of this docume
 
 ### Setup <!-- omit in TOC -->
 
+You can set up your local environment natively or using `docker`, check out the [`docker-compose.yml`](/docker-compose.yml).
+
+Example of running all the checks with docker:
+```bash
+docker-compose run --rm package bash -c "swift test && swift run swiftlint"
+```
+
+To install dependencies:
+
+
 ```bash
 swift build
 ```
@@ -62,9 +72,7 @@ If you want to fix your linting errors:
 swift run swiftlint --fix
 ```
 
-### On Xcode <!-- omit in TOC -->
-
-### Setup <!-- omit in TOC -->
+### Setup on Xcode <!-- omit in TOC -->
 
 To build the project, if it's not already done, click on the play button in the top left corner of Xcode.
 

diff --git a/Dockerfile b/Dockerfile
diff --git a/Sources/MeiliSearch/Client.swift b/Sources/MeiliSearch/Client.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
  A `MeiliSearch` instance represents a Meilisearch client used to easily integrate

diff --git a/Sources/MeiliSearch/Config.swift b/Sources/MeiliSearch/Config.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
  A `Config` instance represents the config used by MeiliSearch instance.

diff --git a/Sources/MeiliSearch/Constants.swift b/Sources/MeiliSearch/Constants.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 struct Constants {
   static let customJSONDecoder: JSONDecoder = {

diff --git a/Sources/MeiliSearch/Documents.swift b/Sources/MeiliSearch/Documents.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 struct Documents {
   // MARK: Properties

diff --git a/Sources/MeiliSearch/Dumps.swift b/Sources/MeiliSearch/Dumps.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
  The dumps route allows the creation of database dumps. Dumps are `.tar.gz` files that

diff --git a/Sources/MeiliSearch/Error.swift b/Sources/MeiliSearch/Error.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
  Represent all error types in the client.

diff --git a/Sources/MeiliSearch/Formatter.swift b/Sources/MeiliSearch/Formatter.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 extension Formatter {
   static let iso8601: DateFormatter = {

diff --git a/Sources/MeiliSearch/Indexes.swift b/Sources/MeiliSearch/Indexes.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 public struct Indexes {
   // MARK: Properties

diff --git a/Sources/MeiliSearch/Keys.swift b/Sources/MeiliSearch/Keys.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 struct Keys {
   // MARK: Properties

diff --git a/Sources/MeiliSearch/Model/Health.swift b/Sources/MeiliSearch/Model/Health.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
  `Health` instances represent the status of the Meilisearch server.

diff --git a/Sources/MeiliSearch/Model/Index.swift b/Sources/MeiliSearch/Model/Index.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
  `Index` instances is an entity that gathers a set of documents with its own settings.

diff --git a/Sources/MeiliSearch/Model/Key.swift b/Sources/MeiliSearch/Model/Key.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
  Each key has a given set of permissions on the API routes.

diff --git a/Sources/MeiliSearch/Model/KeyParams.swift b/Sources/MeiliSearch/Model/KeyParams.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
  `KeyParams` contains all the parameters to create an API key.

diff --git a/Sources/MeiliSearch/Model/PackageVersion.swift b/Sources/MeiliSearch/Model/PackageVersion.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 internal struct PackageVersion {
   /// This is the current version of the meilisearch-swift package

diff --git a/Sources/MeiliSearch/Model/SearchParameters.swift b/Sources/MeiliSearch/Model/SearchParameters.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
  `SearchParameters` instances represent query setup for a search request.

diff --git a/Sources/MeiliSearch/Model/SearchResult.swift b/Sources/MeiliSearch/Model/SearchResult.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
  `SearchResult` instances represent the result of a search.

diff --git a/Sources/MeiliSearch/Model/Setting.swift b/Sources/MeiliSearch/Model/Setting.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
   Settings object provided byb the user

diff --git a/Sources/MeiliSearch/Model/Stat.swift b/Sources/MeiliSearch/Model/Stat.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
  `AllStats` instances represent stat of all Indexes.

diff --git a/Sources/MeiliSearch/Model/Task.swift b/Sources/MeiliSearch/Model/Task.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
  `Task` instances represent the current transaction status, use the `uid` value to

diff --git a/Sources/MeiliSearch/Model/TaskInfo.swift b/Sources/MeiliSearch/Model/TaskInfo.swift
@@ -23,10 +23,6 @@ public struct TaskInfo: Codable, Equatable {
   /// Date when the task has been enqueued.
   public let enqueuedAt: String
 
-  static func == (lhs: TaskInfo, rhs: Task) -> Bool {
-    lhs.taskUid == rhs.uid
-  }
-
   public enum CodingKeys: String, CodingKey {
     case taskUid, indexUid, status, type, enqueuedAt
   }

diff --git a/Sources/MeiliSearch/Model/Version.swift b/Sources/MeiliSearch/Model/Version.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
  `Version` instances represent the current version of the Meilisearch server.

diff --git a/Sources/MeiliSearch/Model/WaitOptions.swift b/Sources/MeiliSearch/Model/WaitOptions.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
  `WaitOptions` struct represent the options used during a waitForTask call.

diff --git a/Sources/MeiliSearch/Request.swift b/Sources/MeiliSearch/Request.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
  Protocol that allows custom implementation of the HTTP layer.
@@ -68,7 +71,6 @@ public final class Request {
     param: String? = nil,
     headers: [String: String] = [:],
     _ completion: @escaping (Result<Data?, Swift.Error>) -> Void) {
-    autoreleasepool {
       var urlString: String = config.url(api: api)
       if let param: String = param, !param.isEmpty {
         urlString += param
@@ -90,7 +92,6 @@ public final class Request {
       }
 
       task.resume()
-    }
   }
 
   func post(

diff --git a/Sources/MeiliSearch/Search.swift b/Sources/MeiliSearch/Search.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 struct Search {
   // MARK: Properties

diff --git a/Sources/MeiliSearch/Settings.swift b/Sources/MeiliSearch/Settings.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
  Settings is a list of all the customization possible for an index.

diff --git a/Sources/MeiliSearch/Stats.swift b/Sources/MeiliSearch/Stats.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 struct Stats {
   // MARK: Properties

diff --git a/Sources/MeiliSearch/System.swift b/Sources/MeiliSearch/System.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 struct System {
   // MARK: Properties

diff --git a/Sources/MeiliSearch/Tasks.swift b/Sources/MeiliSearch/Tasks.swift
@@ -1,4 +1,7 @@
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 /**
   Tasks contains information related to asynchronous tasks in MeiliSearch

diff --git a/Tests/MeiliSearchIntegrationTests/DocumentsTests.swift b/Tests/MeiliSearchIntegrationTests/DocumentsTests.swift
@@ -1,6 +1,9 @@
 @testable import MeiliSearch
 import XCTest
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 // swiftlint:disable force_unwrapping
 // swiftlint:disable force_try
@@ -24,7 +27,7 @@ class DocumentsTests: XCTestCase {
   override func setUp() {
     super.setUp()
     session = URLSession(configuration: .ephemeral)
-    client = try! MeiliSearch(host: "http://localhost:7700", apiKey: "masterKey", session: session)
+    client = try! MeiliSearch(host: currentHost(), apiKey: "masterKey", session: session)
     index = self.client.index(self.uid)
     let expectation = XCTestExpectation(description: "Create index if it does not exist")
     self.client.createIndex(uid: uid) { result in

diff --git a/Tests/MeiliSearchIntegrationTests/DumpsTests.swift b/Tests/MeiliSearchIntegrationTests/DumpsTests.swift
@@ -1,6 +1,9 @@
 @testable import MeiliSearch
 import XCTest
 import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 // swiftlint:disable force_try
 class DumpsTests: XCTestCase {
@@ -13,7 +16,7 @@ class DumpsTests: XCTestCase {
     super.setUp()
     if client == nil {
       session = URLSession(configuration: .ephemeral)
-      client = try! MeiliSearch(host: "http://localhost:7700", apiKey: "masterKey", session: session)
+      client = try! MeiliSearch(host: currentHost(), apiKey: "masterKey", session: session)
     }
   }
 

diff --git a/Tests/MeiliSearchIntegrationTests/IndexesTests.swift b/Tests/MeiliSearchIntegrationTests/IndexesTests.swift
@@ -1,5 +1,9 @@
 @testable import MeiliSearch
 import XCTest
+import Foundation
+#if canImport(FoundationNetworking)
+  import FoundationNetworking
+#endif
 
 // swiftlint:disable force_try
 class IndexesTests: XCTestCase {
@@ -13,7 +17,7 @@ class IndexesTests: XCTestCase {
 
     if client == nil {
       session = URLSession(configuration: .ephemeral)
-      client = try! MeiliSearch(host: "http://localhost:7700", apiKey: "masterKey", session: session)
+      client = try! MeiliSearch(host: currentHost(), apiKey: "masterKey", session: session)
     }
     index = self.client.index(self.uid)