Skip to content

Solve deprecations in DependencyInjection/Configuration.php and Controller/DebugController.php #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solve deprecations in DependencyInjection/Configuration.php and Controller/DebugController.php #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7749d50
Give a parameter to the Treebuilder instance for the root node name. …
aptruchon Mar 29, 2023
0398055
Change the route and template components from Sensio for the Symfony …
aptruchon Mar 29, 2023
b86bd84
Change the Symfony Controller for the Symfony AbstractController sinc…
aptruchon Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Controller/DebugController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@
use Google_Service_AnalyticsReporting_GetReportsRequest;
use Google_Service_AnalyticsReporting_Metric;
use Google_Service_AnalyticsReporting_ReportRequest;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Component\Routing\Annotation\Template;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\Routing\Annotation\Route;

/**
* Class DebugController
* @package MediaFigaro\GoogleAnalyticsApi\Controller
*/
class DebugController extends Controller
class DebugController extends AbstractController
{
/**
* @Route("{viewId}")
Expand Down
4 changes: 2 additions & 2 deletions DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ class Configuration implements ConfigurationInterface
*/
public function getConfigTreeBuilder()
{
$treeBuilder = new TreeBuilder();
$rootNode = $treeBuilder->root('google_analytics_api');
$treeBuilder = new TreeBuilder('google_analytics_api');
$rootNode = $treeBuilder->getRootNode();

$rootNode
->children()
Expand Down