Skip to content

feat: improve scroll behavior #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

feat: improve scroll behavior #283

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b78570
feat: add smooth scroll behavior
jlozovei Oct 26, 2022
0130994
feat: add scroll margin top to topic title
jlozovei Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 41 additions & 25 deletions _sass/_og.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@
--blue-300: #6ea8fe;
--blue-700: #084298;

--font: Inter, -apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, Arial, sans-serif;
--font: Inter, -apple-system, BlinkMacSystemFont, 'Segoe UI', Helvetica, Arial, sans-serif;
--font-heading: InterDisplay;

--body-bg: #fff;
--body-color: #212529;
--secondary-color: #6c757d;
--border-color: rgba(0, 0, 0, .1);
--border-color: rgba(0, 0, 0, 0.1);
--accent-bg: #f8f9fa;
--link-color: var(--blue);
--masthead-bg: var(--accent-bg);
Expand All @@ -39,7 +39,7 @@
--body-color: #dee2e6;
--accent-bg: #2a2f34;
--link-color: var(--blue-300);
--border-color: rgba(255, 255, 255, .1);
--border-color: rgba(255, 255, 255, 0.1);
}
}

Expand All @@ -53,6 +53,11 @@ html {
font-size: 16px;
font-family: var(--font);
line-height: 1.5;
scroll-behavior: smooth;

@media screen and (prefers-reduced-motion: reduce) {
scroll-behavior: auto;
}
}

body {
Expand All @@ -74,17 +79,28 @@ a {
}
}

h1, h2, h3, h4 {
h1,
h2,
h3,
h4 {
margin-top: 0;
margin-bottom: .5rem;
margin-bottom: 0.5rem;
font-family: var(--font-heading), var(--font);
font-weight: 600;
line-height: 1;
}
h1 { font-size: 2.5rem; }
h2 { font-size: 2rem; }
h3 { font-size: 1.75rem; }
h4 { font-size: 1.5rem }
h1 {
font-size: 2.5rem;
}
h2 {
font-size: 2rem;
}
h3 {
font-size: 1.75rem;
}
h4 {
font-size: 1.5rem;
}

p {
margin-top: 0;
Expand All @@ -108,10 +124,12 @@ ul {

li {
padding-inline-start: 1.5ch;
margin-bottom: .25rem;
list-style-type: "—";
margin-bottom: 0.25rem;
list-style-type: '—';

&::marker { color: var(--secondary-color); }
&::marker {
color: var(--secondary-color);
}
}

p:last-child,
Expand All @@ -120,20 +138,19 @@ blockquote:last-child {
margin-bottom: 0;
}


//
// Code
//

code,
pre {
font-family: "SFMono-Regular", Menlo, "Courier New", monospace;
font-family: 'SFMono-Regular', Menlo, 'Courier New', monospace;
font-size: 95%;
}
code {
font-size: 85%;
color: var(--pink);
border-radius: .2rem;
border-radius: 0.2rem;
}

pre {
Expand Down Expand Up @@ -165,7 +182,6 @@ pre {
}
}


//
// Masthead
//
Expand All @@ -174,7 +190,7 @@ pre {
display: block;
width: 128px;
height: 128px;
margin-left: -.75rem;
margin-left: -0.75rem;
margin-bottom: 1.5rem;

@media (min-width: 768px) {
Expand Down Expand Up @@ -204,7 +220,7 @@ pre {
margin-bottom: 1rem;
font-size: 4rem;
font-weight: 700;
line-height: .9;
line-height: 0.9;
color: inherit;

@media (min-width: 768px) {
Expand All @@ -223,7 +239,6 @@ pre {
}
}


//
// Content
//
Expand All @@ -246,6 +261,10 @@ pre {
flex-direction: column;
gap: var(--gap);

h3 {
scroll-margin-top: 24px;
}

@media (min-width: 768px) {
display: grid;
grid-template-columns: repeat(2, 1fr);
Expand All @@ -262,7 +281,6 @@ pre {
}
}


//
// The Grid
//
Expand All @@ -274,7 +292,6 @@ pre {
}
}


//
// Sections
//
Expand All @@ -283,10 +300,9 @@ h2 {
padding-top: 1rem;
margin-top: 3rem;
margin-bottom: 0;
border-top: .25rem solid;
border-top: 0.25rem solid;
}


//
// Footer
//
Expand All @@ -296,11 +312,11 @@ h2 {
padding-top: 3rem;
padding-bottom: 3rem;
margin-top: 5rem;
border-top: .25rem solid;
border-top: 0.25rem solid;
}

.footer p {
margin-bottom: .5rem;
margin-bottom: 0.5rem;
}

.quick-links {
Expand Down