-
Notifications
You must be signed in to change notification settings - Fork 157
Adding some small features and one bug fix #28
base: gh-pages
Are you sure you want to change the base?
Conversation
Add json-change-key attribute to directive so now it is possible to switch on/off changing key Add json-change-order attribute to directive so now it is possible to switch on/off changing ordering of array child Add json-add attribute to directive so now it is possible to switch on/off adding new capability Add json-delete attribute to directive so now it is possible to switch on/off deleting capability
|
@mb21 @LiterallyElvis is there any problem with my changes and my merge request? My only intention was to help this project. but no one care any more here. |
|
So which change exactly fixes the array editing? I'm not sure I want to merge the added features since they complicate the code and I'd rather have this version stay as simple as possible, people can then customize it to their liking (like you did). |
|
Customizing it to ones liking works to an extent, however, consider if someone is using a bower.json which will always install your master branch. This would force everyone else who clones a project using this tool to make the same changes to fix this. The changes made by @ParidelPooya don't "complicate" the code, they fix the code which was very obviously broken. @ParidelPooya thank you very much for your contributions! |
|
I agree with @jtreleaven, I think this change makes it function the way a user would expect. I don't think that editing an array and expecting that data to bind both ways should require customization. |
|
Okay, I extracted from this pull request what seems to fix the array editing bug, see b2d3022. |
Hi
I changed JSONedit a little for my project and I think these changes are useful:
-Bug fix: Array values now changed correctly.
-Add json-change-key attribute to directive so now it is possible to switch on/off changing key.
-Add json-change-order attribute to directive so now it is possible to switch on/off changing ordering of array child.
-Add json-add attribute to directive so now it is possible to switch on/off adding new capability.
-Add json-delete attribute to directive so now it is possible to switch on/off deleting capability.