Add new domain outputs #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oschwald
commented
Nov 18, 2025
oschwald
commented
- Add CLAUDE.md with development guidance
- Update to .NET 10.0 and C# 14.0
- Use C# 14 field keyword for property backing fields
- Add email domain outputs to minFraud Insights and Factors
This file provides architectural guidance and development instructions for Claude Code when working with this repository, including build/test commands, design patterns, and conventions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add net10.0 as a target framework for both main library and test project - Update language version from 13.0 to 14.0 - Update CLAUDE.md to reflect new version requirements - All 170 tests pass on .NET 10.0 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Replace explicit backing fields with the new C# 14 `field` keyword in properties with custom validation logic. This eliminates boilerplate code while maintaining the same functionality. Files updated: - Device.cs: SessionAge, SessionId (2 properties) - Order.cs: Currency (1 property) - TransactionReport.cs: MaxMindId (1 property) - CreditCard.cs: Country, IssuerIdNumber, LastDigits, Token (4 properties) - Location.cs: Country (1 property) Total: 9 backing fields eliminated across 5 files Note: Email.cs was not updated as it has cross-property assignment between Address and Domain backing fields, which is incompatible with the field keyword pattern. Updated CLAUDE.md to document the field keyword pattern and provide examples for future contributors. All 170 tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
This adds support for new email domain outputs available in minFraud Insights and Factors responses: - /email/domain/classification - Domain type (business, education, government, isp_email) - /email/domain/risk - Domain risk score (0.01-99) - /email/domain/volume - Activity indicator across minFraud network - /email/domain/visit/has_redirect - Whether domain redirects - /email/domain/visit/last_visited_on - Date of last automated inspection - /email/domain/visit/status - Domain status (live, dns_error, network_error, http_error, parked, pre_development) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
oschwald
force-pushed
the
greg/eng-3458-minfraud-api-dotnet-add-email-domain-outputs
branch
from
debfd93 to
db61ff5
Compare
…ated Remove manual dotnet-outdated step from release process since we use Dependabot for automated dependency updates. Add explicit mention of reviewing Dependabot PRs in the release checklist. Fix step numbering. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
horgh
approved these changes
Nov 19, 2025
horgh
deleted the
greg/eng-3458-minfraud-api-dotnet-add-email-domain-outputs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.