Skip to content

Bump actions/setup-java from 1 to 3 #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2022
Merged

Bump actions/setup-java from 1 to 3 #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11f4332
Bump actions/setup-java from 1 to 3
dependabot[bot] Aug 30, 2022
c1e6091
Set distribution
oschwald Aug 30, 2022
da92967
Add missing params in docs
oschwald Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@ jobs:
strategy:
fail-fast: false
matrix:
distribution: ['zulu']
os: [ubuntu-latest, windows-latest, macos-latest]
version: [ 8, 9, 10, 11, 12, 13, 14, 15 ]
steps:
- uses: actions/checkout@v3
with:
submodules: true
- uses: actions/setup-java@v1
- uses: actions/setup-java@v3
with:
distribution: ${{ matrix.distribution }}
java-version: ${{ matrix.version }}
- run: mvn test -B
3 changes: 3 additions & 0 deletions src/main/java/com/maxmind/db/Reader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ private Reader(BufferHolder bufferHolder, String name, NodeCache cache) throws I
/**
* Looks up <code>ipAddress</code> in the MaxMind DB.
*
* @param <T> the type to populate.
* @param ipAddress the IP address to look up.
* @param cls the class of object to populate.
* @return the object.
Expand All @@ -153,7 +154,9 @@ public <T> T get(InetAddress ipAddress, Class<T> cls) throws IOException {
/**
* Looks up <code>ipAddress</code> in the MaxMind DB.
*
* @param <T> the type to populate.
* @param ipAddress the IP address to look up.
* @param cls the class of object to populate.
* @return the record for the IP address. If there is no data for the
* address, the non-null {@link DatabaseRecord} will still be returned.
* @throws IOException if a file I/O error occurs.
Expand Down